Skip to content

Conversation

@missingn0pe
Copy link
Member

Description

Adding new key phrasing in subject & display text.

Associated samples

- Sample 1

Associated hunts

- Hunt 1

Adding new key phrasing in subject & display text
@missingn0pe missingn0pe requested a review from a team as a code owner December 30, 2025 22:30
@github-actions github-actions bot added the in-test-rules PR is in our testing suite to collect telemetry label Dec 30, 2025
Added additional negation to filter out links related to privacy policies and registration. These are the only FP's currently
@missingn0pe missingn0pe changed the title Refine regex patterns for phishing detection Update Corporate Impersonation Key Phrasing Jan 9, 2026
@missingn0pe
Copy link
Member Author

Reviewing FP's over the last week, seems the only new FP hits have been Privacy Policy phrasings in body links. Adding negation resolves.

@missingn0pe missingn0pe added the review-needed Indicates that a PR is waiting for review label Jan 9, 2026
missingn0pe and others added 3 commits January 9, 2026 14:20
Co-authored-by: Brandon Murphy <[email protected]>
Co-authored-by: Brandon Murphy <[email protected]>
Co-authored-by: Brandon Murphy <[email protected]>
Comment on lines 71 to 72
and not strings.ilike(.display_text, "*privacy?policy*")
and not strings.ilike(.href_url.url, "*privacy?policy*")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
and not strings.ilike(.display_text, "*privacy?policy*")
and not strings.ilike(.href_url.url, "*privacy?policy*")
and not strings.ilike(.display_text, "*privacy?policy*")
and not strings.ilike(.href_url.url, "*privacy?policy*")

nit

@zoomequipd
Copy link
Member

Mode results are a little misleading. Looks like most of the "net new" are actually a result of localized tuning.

@missingn0pe missingn0pe enabled auto-merge January 15, 2026 16:14
@github-actions github-actions bot removed the in-test-rules PR is in our testing suite to collect telemetry label Jan 15, 2026
github-actions bot added a commit that referenced this pull request Jan 15, 2026
@github-actions github-actions bot added the in-test-rules PR is in our testing suite to collect telemetry label Jan 15, 2026
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-test-rules PR is in our testing suite to collect telemetry review-needed Indicates that a PR is waiting for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants